CLN: Update .format(...) strings to f-expressions #29571
Merged
+32
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks - please link the issue #29547 |
|
CI failures related to black Please run |
datapythonista
changed the title
There was a problem hiding this comment.
Thanks for working on this @srinivasreddy. Please run black asv_bench/benchmarks/gil.py and push the changes, so the CI is green and we can merge.
Also, avoid unrelated changes if they are not coming from black.
asv_bench/benchmarks/gil.py
Outdated
| "foo", | ||
| index=range(rows), | ||
| columns=["object%03d".format(i) for i in range(5)], | ||
| "foo", index=range(rows), columns=[f"object%03d" for i in range(5)], |
There was a problem hiding this comment.
i was ignored, no need for an f-string here I think
pandas/core/algorithms.py
Outdated
| @@ -1159,7 +1159,7 @@ def compute(self, method): | |||
| n = min(n, narr) | |||
|
|
|||
| kth_val = algos.kth_smallest(arr.copy(), n - 1) | |||
| ns, = np.nonzero(arr <= kth_val) | |||
| (ns,) = np.nonzero(arr <= kth_val) | |||
There was a problem hiding this comment.
I guess this is from black. Can you use the version in environment.yml (conda install black<=19.3b0), so no unrelated changes are applied.
datapythonista
approved these changes
Nov 14, 2019
|
thanks @srinivasreddy |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff