-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REF: implement cumulative ops block-wise #29872
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Would be good to have a release note and some tests that exercise this directly.
ok with moving this later, does this need a whatsnew note / additional tests as @TomAugspurger asks? |
So far i haven't been able to write tests that fail without this. Haven't given up. |
do @TomAugspurger original tests work on master? |
good point! no, but they work here. will update |
Hello @jbrockmendel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-12-27 20:23:03 UTC |
same unrelated-looking docbuild failure as #29847. im guessing this is going to be affecting all PRs about now, will take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good to go.
thanks, looking forward to the cleanups! |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
cc @TomAugspurger