Skip to content

CI: added unwanted pattern test case for "foo.__class__" instead of type(foo) #29937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 1, 2019
Merged

CI: added unwanted pattern test case for "foo.__class__" instead of type(foo) #29937

merged 4 commits into from
Dec 1, 2019

Conversation

ShaharNaveh
Copy link
Contributor

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

ref #29816 (splitted to #29889, #29893, #29894, #29902, #29904, #29905)

@ShaharNaveh ShaharNaveh changed the title Added unwanted pattern test case CI: added unwanted pattern test case for ".__class__" instead of type() Nov 30, 2019
@ShaharNaveh ShaharNaveh changed the title CI: added unwanted pattern test case for ".__class__" instead of type() CI: added unwanted pattern test case for "foo.__class__" instead of type(foo) Nov 30, 2019
@jbrockmendel jbrockmendel added CI Continuous Integration Code Style Code style, linting, code_checks labels Nov 30, 2019
@WillAyd
Copy link
Member

WillAyd commented Nov 30, 2019

Looks good. To be sure can you intentionally change the code somewhere to make this fail so we can see how it looks in CI?

@WillAyd WillAyd added this to the 1.0 milestone Nov 30, 2019
@ShaharNaveh
Copy link
Contributor Author

ping @WillAyd

@alimcmaster1
Copy link
Member

image

This is how it looks in CI. Might be worth adding something that explains one should use type()?

@WillAyd WillAyd merged commit 9d528bf into pandas-dev:master Dec 1, 2019
@WillAyd
Copy link
Member

WillAyd commented Dec 1, 2019

Great thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the CI-test-case-for-dunderClass branch December 1, 2019 20:46
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
CI: added unwanted pattern test case for "foo.__class__" instead of t…
9e08778 
…ype(foo) (pandas-dev#29937)
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
CI: added unwanted pattern test case for "foo.__class__" instead of t…
1e9461f 
…ype(foo) (pandas-dev#29937)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees

No one assigned

Labels

CI Continuous Integration Code Style Code style, linting, code_checks

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ShaharNaveh @WillAyd @alimcmaster1 @jbrockmendel