Skip to content

CI: troubleshoot codecov #30070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2019
Merged

Conversation

jbrockmendel
Copy link
Member

The results here https://codecov.io/gh/pandas-dev/pandas/tree/master/pandas are 17 days old, the last attempt to re-enable codecov apparently didn't take. Trying again.

@jbrockmendel jbrockmendel added the CI Continuous Integration label Dec 5, 2019
echo "bash <(curl -s https://codecov.io/bash) -Z -c -F $TYPE -f $COVERAGE_FNAME"
bash <(curl -s https://codecov.io/bash) -Z -c -F $TYPE -f $COVERAGE_FNAME
echo "bash <(curl -s https://codecov.io/bash) -Z -c -F $TYPE -f $COVERAGE_FNAME -C $SHA"
bash <(curl -s https://codecov.io/bash) -Z -c -F $TYPE -f $COVERAGE_FNAME -C `git rev-parse HEAD`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be SHA as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is reverting to what we had before we disabled this (will need caffeine before tracking down the appropriate xref)

@jbrockmendel jbrockmendel mentioned this pull request Dec 6, 2019
5 tasks
@jbrockmendel
Copy link
Member Author

Do we have any way (other than merging) to tell if this will actually accomplish the goal of getting codecov updated?

@jbrockmendel
Copy link
Member Author

Any objections to the "merge this and see if it works" style of debugging here?

@jbrockmendel
Copy link
Member Author

@WillAyd gentle ping

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Not super well versed with codecov but merge away if it’s going to help out

@jbrockmendel jbrockmendel merged commit b4343ef into pandas-dev:master Dec 20, 2019
@jbrockmendel jbrockmendel deleted the ci-codecov branch December 20, 2019 05:39
@jbrockmendel
Copy link
Member Author

@thomasrockhu any ideas what we're doing wrong here? pandas codecov page stopped updating about a month ago

@thomasrockhu
Copy link

@jbrockmendel taking a look now! thanks for bringing this to our attention

@thomasrockhu
Copy link

@jbrockmendel looks like it's a problem with how $TYPE is getting set (or that it's not getting set). As an example, right now the call to Codecov is

bash <(curl -s https://codecov.io/bash) -Z -c -F  -f /tmp/test_coverage.xml -C b4343efa33c9456694bcfd6dee7bf5941288966b

Since the flags -F flag is empty, it's pulling -f as the value. Let me know if this helps!

@jbrockmendel
Copy link
Member Author

@thomasrockhu Thanks for the quick feeedback. It looks like the TYPE variable stopped getting defined in #28531, so im going to just remove that and see if it does the trick.

AlexKirko pushed a commit to AlexKirko/pandas that referenced this pull request Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants