-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CI: troubleshoot codecov #30070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: troubleshoot codecov #30070
Conversation
echo "bash <(curl -s https://codecov.io/bash) -Z -c -F $TYPE -f $COVERAGE_FNAME" | ||
bash <(curl -s https://codecov.io/bash) -Z -c -F $TYPE -f $COVERAGE_FNAME | ||
echo "bash <(curl -s https://codecov.io/bash) -Z -c -F $TYPE -f $COVERAGE_FNAME -C $SHA" | ||
bash <(curl -s https://codecov.io/bash) -Z -c -F $TYPE -f $COVERAGE_FNAME -C `git rev-parse HEAD` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be SHA as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is reverting to what we had before we disabled this (will need caffeine before tracking down the appropriate xref)
Do we have any way (other than merging) to tell if this will actually accomplish the goal of getting codecov updated? |
Any objections to the "merge this and see if it works" style of debugging here? |
@WillAyd gentle ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Not super well versed with codecov but merge away if it’s going to help out
@thomasrockhu any ideas what we're doing wrong here? pandas codecov page stopped updating about a month ago |
@jbrockmendel taking a look now! thanks for bringing this to our attention |
@jbrockmendel looks like it's a problem with how
Since the flags |
@thomasrockhu Thanks for the quick feeedback. It looks like the TYPE variable stopped getting defined in #28531, so im going to just remove that and see if it does the trick. |
The results here https://codecov.io/gh/pandas-dev/pandas/tree/master/pandas are 17 days old, the last attempt to re-enable codecov apparently didn't take. Trying again.