Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Error thrown when None is passed to pd.to_datetime() with format as %Y%m%d #30083

Merged
merged 16 commits into from
Dec 12, 2019
Merged

Fixes Error thrown when None is passed to pd.to_datetime() with format as %Y%m%d #30083

merged 16 commits into from
Dec 12, 2019

Conversation

maheshbapatu
Copy link
Contributor

@maheshbapatu maheshbapatu commented Dec 5, 2019 •
edited
Loading

@maheshbapatu maheshbapatu changed the title Closes #30011 Fixes Error thrown when None is passed to pd.to_datetime() with format as %Y%m%d Fixes Error thrown when None is passed to pd.to_datetime() with format as %Y%m%d Dec 5, 2019
@jbrockmendel
Copy link
Member

can you add a test for the behavior this fixes

jreback
jreback requested changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also pls add a whatsnew note, bug fixes for datetimelike in v1.0.0

@jreback jreback added Bug Datetime Datetime data dtype labels Dec 5, 2019
@maheshbapatu
Copy link
Contributor Author

Updated about the issue and versions in Whats new entry row

@maheshbapatu maheshbapatu requested a review from jreback December 6, 2019 19:49
jreback
jreback requested changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments + pls add a whtasnew entry in bug fixes for 1.0.0 in datetime section

pandas/tests/indexes/datetimes/test_tools.py Outdated Show resolved Hide resolved
pandas/tests/indexes/datetimes/test_tools.py Outdated Show resolved Hide resolved
@pep8speaks
Copy link

pep8speaks commented Dec 7, 2019 •
edited
Loading

Hello @maheshbapatu! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-10 19:39:49 UTC

@maheshbapatu
Copy link
Contributor Author

comments + pls add a whtasnew entry in bug fixes for 1.0.0 in datetime section

Can you please elaborate about adding a whats new entry for 1.0.0 in datetime section. This is first commit of mine in open source field. Will be elated if you could describe it in detail .

@maheshreddybapatu
This avoids failure to_datetime when value passed is None. This fix i…
4dc5a3a 
…s for pandas versions > 0.24

closes pandas-dev#30011
@maheshreddybapatu
This avoids failure to_datetime when value passed is None. This fix i…
d6297b2 
…s pandas versions > 0.24.

Closes pandas-dev#30011
@maheshreddybapatu
This avoids failure to_datetime when value passed is None. This fix i…
7157af5 
…s pandas versions > 0.24.

Closes pandas-dev#30011
@maheshreddybapatu
This avoids failure to_datetime when value passed is None. This fix i…
2a5a687 
…s pandas versions > 0.24.

Closes pandas-dev#30011
@maheshreddybapatu
This avoids failure to_datetime when value passed is None. This fix i…
6aee7ce 
…s pandas versions > 0.24.

Closes pandas-dev#30011
@maheshreddybapatu
This avoids failure to_datetime when value passed is None. This fix i…
5c1d919 
…s pandas versions > 0.24.

Closes pandas-dev#30011
@mroeschke
Copy link
Member

@maheshbapatu For bug fixes, we include a description of what was fixed in a "whatsnew" document when the library is released. Specifically, please put the description here: https://github.com/pandas-dev/pandas/blob/master/doc/source/whatsnew/v1.0.0.rst#datetimelike

@jreback jreback mentioned this pull request Dec 8, 2019
Closed
5 tasks
@maheshreddybapatu
This avoids failure in to_datetime when value passed is None. After c…
c07c1cf 
…hanges it will return NaT instead of TypeError.…
@maheshbapatu
Copy link
Contributor Author

@maheshbapatu For bug fixes, we include a description of what was fixed in a "whatsnew" document when the library is released. Specifically, please put the description here: https://github.com/pandas-dev/pandas/blob/master/doc/source/whatsnew/v1.0.0.rst#datetimelike

Thanks @mroeschke got it added changes accordingly.

jreback
jreback requested changes Dec 8, 2019
View reviewed changes
doc/source/whatsnew/v1.0.0.rst Outdated Show resolved Hide resolved
pandas/tests/indexes/datetimes/test_tools.py Show resolved Hide resolved
@jreback jreback added this to the 1.0 milestone Dec 8, 2019
@maheshbapatu maheshbapatu requested a review from jreback December 10, 2019 03:58
@maheshbapatu maheshbapatu requested a review from jreback December 11, 2019 03:52
@jreback jreback merged commit 76ddd78 into pandas-dev:master Dec 12, 2019
@jreback
Copy link
Contributor

jreback commented Dec 12, 2019

thanks @maheshbapatu very nice

@maheshbapatu
Copy link
Contributor Author

Thanks a lot @jreback and everyone who helped me all the way in my first open source contribution

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@maheshrbapatu @proost
Fixes Error thrown when None is passed to pd.to_datetime() with forma…
42eb0d2 
…t as %Y%m%d (pandas-dev#30083)
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@maheshrbapatu @proost
Fixes Error thrown when None is passed to pd.to_datetime() with forma…
ad6283c 
…t as %Y%m%d (pandas-dev#30083)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Bug Datetime Datetime data dtype
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Crash when pd.to_datetime gets a None for certain values of format
6 participants
@maheshbapatu @jbrockmendel @pep8speaks @mroeschke @jreback @maheshreddybapatu