Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaned Up setup.py includes #30201

Merged
merged 6 commits into from
Dec 12, 2019
Merged

Cleaned Up setup.py includes #30201

merged 6 commits into from
Dec 12, 2019

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Dec 11, 2019

Looking to make these more explicit and remove where not required

@pep8speaks
Copy link

pep8speaks commented Dec 11, 2019 •
edited
Loading

Hello @WillAyd! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-12 18:28:45 UTC

@jreback jreback added the Clean label Dec 11, 2019
@jreback jreback added this to the 1.0 milestone Dec 11, 2019
@jreback
Copy link
Contributor

jreback commented Dec 11, 2019

should rebase this after we merge #30112

@jbrockmendel
Copy link
Member

LGTM

@jbrockmendel
Copy link
Member

needs rebase

@WillAyd WillAyd merged commit 1a1aebb into pandas-dev:master Dec 12, 2019
@WillAyd WillAyd deleted the simplified-setup branch December 12, 2019 21:07
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@WillAyd @proost
Cleaned Up setup.py includes (pandas-dev#30201)
596ab94
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@WillAyd @proost
Cleaned Up setup.py includes (pandas-dev#30201)
5bfb142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@WillAyd @pep8speaks @jreback @jbrockmendel