Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: change DataFrame.append default sort kwarg #30251

Merged
merged 2 commits into from
Dec 15, 2019

Conversation

jbrockmendel
Copy link
Member

xref #20613

AFAICT this doesn't break any tests, was this supposed to have been changed along with the default in concat #29786 ?

Co-Authored-By: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@jreback jreback added the Deprecate Functionality to remove in pandas label Dec 13, 2019
@jreback jreback added this to the 1.0 milestone Dec 13, 2019
@jreback
Copy link
Contributor

jreback commented Dec 13, 2019

xref #20613

AFAICT this doesn't break any tests, was this supposed to have been changed along with the default in concat #29786 ?

IIRC this was changed already for 1.0, so may need to delay this

@jbrockmendel
Copy link
Member Author

IIRC this was changed already for 1.0, so may need to delay this

The last time the relevant part of the docstring was changed was in #20613, the same PR that deprecated the old pd.concat default behavior.

@jreback jreback merged commit cd04280 into pandas-dev:master Dec 15, 2019
@jreback
Copy link
Contributor

jreback commented Dec 15, 2019

thanks @jbrockmendel must have been thinking about something else

@jbrockmendel jbrockmendel deleted the depr-append-sort branch December 16, 2019 01:06
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants