REF: refactor cumulative op tests from test_analytics #30358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
added
Refactor
WillAyd
approved these changes
Dec 20, 2019
| import pandas.util.testing as tm | ||
|
|
||
|
|
||
| class TestDataFrameCumulativeOps: |
There was a problem hiding this comment.
Not a huge deal but probably don't even need the classes now
There was a problem hiding this comment.
for whatever reason i still find this style more comfortable, but agreed on the "not a huge deal"
|
thanks. i kind of like the classes as well, useful for organizing, but equally can just make a directory and a no-class structure. prob not worth the churn though. |
AlexKirko
pushed a commit
to AlexKirko/pandas
that referenced
this pull request
Dec 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removal of
ixhighlighted how difficult it is to tell how thorough tests are for some funcs/methods. This is one of several PRs intended to clarify where the tests for X live, and ideally to make that follow a standard pattern across DataFrame/Series/Index subclasses (and EA where relevant)