Skip to content

REF: directory for method-specific series/frame tests #30362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2019
Merged

REF: directory for method-specific series/frame tests #30362

merged 1 commit into from
Dec 20, 2019

Conversation

jbrockmendel
Copy link
Member

Per the docstring in each of the new directories:

Test files dedicated to individual (stand-alone) DataFrame methods

Ideally these files/tests should correspond 1-to-1 with tests.series.methods

These may also present opportunities for sharing/de-duplicating test code.

If this approach is approved, I'll then go through the remaining test files (in particular test_analytics) for things that have become "misc" piles.

@jbrockmendel jbrockmendel added Testing pandas testing functions or related to the test suite Refactor Internal refactoring of code labels Dec 20, 2019
WillAyd
WillAyd approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simonjayhawkins simonjayhawkins added this to the 1.0 milestone Dec 20, 2019
@jreback jreback merged commit 1be80ea into pandas-dev:master Dec 20, 2019
@jreback
Copy link
Contributor

jreback commented Dec 20, 2019

sure

@jbrockmendel jbrockmendel deleted the ref-tst-methods branch December 20, 2019 16:18
AlexKirko pushed a commit to AlexKirko/pandas that referenced this pull request Dec 29, 2019
@jbrockmendel @AlexKirko
REF: directory for method-specific series/frame tests (pandas-dev#30362)
af254f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jbrockmendel @jreback @WillAyd @simonjayhawkins