STY: Underscores for long numbers #30397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
requested changes
Dec 22, 2019
| [ | ||
| 946_688_461_000_000_000 / 1_000_000_000.0 + 0.5, | ||
| dict(unit="s", us=500000), | ||
| ], |
There was a problem hiding this comment.
IMO these don't improve legibility compared to the old ones. I'd prefer the old way to keep a single line per parameter.
ShaharNaveh
force-pushed
the
STY-tests-underscores
branch
from
01fc0b5 to
baef48d
Compare
|
Hello @MomIsBestFriend! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-12-22 12:18:12 UTC |
ShaharNaveh
force-pushed
the
STY-tests-underscores
branch
from
baef48d to
0d7540b
Compare
topper-123
approved these changes
Dec 22, 2019
|
Thanks, @MomIsBestFriend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff