REF: use _get_string_slice in PeriodIndex.get_value #31058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
commented
Jan 16, 2020
| grp = resolution.Resolution.get_freq_group(reso) | ||
| freqn = resolution.get_freq_group(self.freq) | ||
| if reso in ["day", "hour", "minute", "second"] and not grp < freqn: | ||
| raise KeyError(key) |
Member
Author
There was a problem hiding this comment.
@jreback i think you wrote most of this, do you remember what the reso checks here are for?
jbrockmendel
added
the
Indexing
Contributor
|
needs a rebase, this overalaps with #31096 ? |
Member
Author
rebased+green. the diff overlaps so 31096 will probably need to be rebased, but they are logically independent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of _get_string_slice is duplicated inside PeriodIndex.get_value, which likely explains why get_string_slice has almost no test coverage. This also brings PeriodIndex.get_value into closer alignment with DatetimeIndex.get_value, so we may be able to share code a few steps from here.