Skip to content

CI: Fix Assign CI not working with quotes #31237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 25, 2020
Merged

CI: Fix Assign CI not working with quotes #31237

merged 3 commits into from
Jan 25, 2020

Conversation

lithomas1
Copy link
Member

@lithomas1 lithomas1 commented Jan 23, 2020

Examples(all three passed)
image

@datapythonista
Copy link
Member

Thanks for working on this. Do you know why this works? I'm wondering if it's because the content of the variable is assigned and taking a substring is having no effect.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is much better. But it just came to my mind, that we should be able to do the comparison before fetching the content of the variable. I think the next or something similar should work:

if [[ "${{ github.event.comment.body == "take" }}" == "true" ]]; then

Github actions supports expressions with operators, and even some functions, you can find more info at:
https://help.github.com/en/actions/automating-your-workflow-with-github-actions/contexts-and-expression-syntax-for-github-actions#operators

Thanks!

@lithomas1
Copy link
Member Author

@datapythonista I think I got it now.
Can you take another look? Thanks.

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@datapythonista datapythonista merged commit e7b6a25 into pandas-dev:master Jan 25, 2020
@datapythonista
Copy link
Member

Thanks @lithomas1, I think this fix is better than what I proposed.

For the next time, I recommend you use a hit branch, and not work directly in master.

(Just trying " this, to see if it works as expected).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Action to assign issues fails when quotes are present
3 participants