Skip to content

DOC: separate section with experimental features in 1.0.0 whatsnew #31429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2020

Conversation

jorisvandenbossche
Copy link
Member

Just a thought I had, to put the experimental features (pd.NA, string, boolean dtypes) in a separate section, better highlighting that those are experimental.

Since @TomAugspurger basically wants to release now, this is certainly not a blocker :)

@TomAugspurger
Copy link
Contributor

Would maybe put the "Experimental New Features" before the "Other Features", but +1 otherwise.

@TomAugspurger
Copy link
Contributor

Doc build finished. Merging.

@TomAugspurger TomAugspurger merged commit eda68cf into pandas-dev:master Jan 29, 2020
@TomAugspurger TomAugspurger added this to the 1.0.0 milestone Jan 29, 2020
@TomAugspurger
Copy link
Contributor

@meeseeksdev backport to 1.0.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 29, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.0.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 eda68cfcda90efdc9c11c1a77094eb0f13a8b1b4
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #31429: DOC: separate section with experimental features in 1.0.0 whatsnew'
  1. Push to a named branch :
git push YOURFORK 1.0.x:auto-backport-of-pr-31429-on-1.0.x
  1. Create a PR against branch 1.0.x, I would have named this PR:

"Backport PR #31429 on branch 1.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@TomAugspurger
Copy link
Contributor

Handling the backport. Not sure why it wouldn't be clean.

@jorisvandenbossche jorisvandenbossche deleted the doc-whatsnew branch January 29, 2020 21:10
TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request Jan 29, 2020
…andas-dev#31429)

* DOC: separate section with experimental features in 1.0.0 whatsnew
TomAugspurger added a commit that referenced this pull request Jan 29, 2020
…31429) (#31431)

* DOC: separate section with experimental features in 1.0.0 whatsnew

Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants