Skip to content

TYP: Type annotaion for test decorators #31454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ShaharNaveh
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

I am not 100% sure this is something we want, or at least with this implementation.

cc @simonjayhawkins

@pep8speaks
Copy link

pep8speaks commented Jan 30, 2020

Hello @MomIsBestFriend! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-01-30 15:52:49 UTC

MomIsBestFriend added 2 commits January 30, 2020 17:09
@simonjayhawkins
Copy link
Member

I am not 100% sure this is something we want, or at least with this implementation.

eventually.

typing was original done like this, but changed in #28134, since _pytest.mark.structures.MarkDecorator currently resolves to Any.

for the current status of typing in pytest see pytest-dev/pytest#3342

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Jan 30, 2020
@ShaharNaveh
Copy link
Member Author

I see that is related to #28133, I thought about helping there, but I don't know how to do it without stub files.

So I am closing this :)

sorry for your time @simonjayhawkins

@ShaharNaveh ShaharNaveh deleted the TYP-_test_decorators branch January 30, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants