BUG&TST: df.replace fail after converting to new dtype #31545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was solved by #31484 and here add a test to prove it works now, and thus close the issue, i think a whatsnew is not needed in this case |
|
|
||
| def test_replace_after_convert_dtypes(self): | ||
| # GH31517 | ||
| df = pd.DataFrame({"grp": [1, 2, 3, 4, 5]}) |
There was a problem hiding this comment.
I would just specify it here as dtype="Int64" instead of using convert_dtypes (in the end, the issue was that replace didn't work with Int64 data, the convert_dtypes was just a way to get such dtype)
There was a problem hiding this comment.
oh yeah, i was copying-pasting the example in issue description, sorry for my laziness. 😅 changed!
jreback
added
Bug
Dtype Conversions
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 1, 2020
…ng to new dtype
|
thanks @charlesdong1991 backporting this to ensure that 1.0.x is tested as well. |
jreback
pushed a commit
to jreback/pandas
that referenced
this pull request
Feb 2, 2020
…ng to new dtype
jreback
added a commit
that referenced
this pull request
Feb 2, 2020
…dtype (#31584) Co-authored-by: Kaiqi Dong <kaiqidong1991@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff