Skip to content

Conversation

alimcmaster1
Copy link
Member

@jorisvandenbossche
Copy link
Member

Can you use the same format (the sections) as the v1.0.1 file ?

@jorisvandenbossche
Copy link
Member

And you can also already fill in the "contributor" (see the v1.0.1 file for how it is done there)

@alimcmaster1
Copy link
Member Author

Thanks - Done @jorisvandenbossche

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added this to the 1.0.2 milestone Feb 6, 2020
@jorisvandenbossche
Copy link
Member

@alimcmaster1 I removed the deprecation section as well, as normally there shouldn't be any deprecations (in 1.0.1 it was a special case to fix a regression that it was restored but also deprecated)

@jorisvandenbossche jorisvandenbossche merged commit 120f35f into pandas-dev:master Feb 6, 2020
@jorisvandenbossche
Copy link
Member

Thanks!

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Feb 6, 2020
jorisvandenbossche pushed a commit that referenced this pull request Feb 6, 2020
Co-authored-by: alimcmaster1 <alimcmaster1@gmail.com>
@alimcmaster1
Copy link
Member Author

@alimcmaster1 I removed the deprecation section as well, as normally there shouldn't be any deprecations (in 1.0.1 it was a special case to fix a regression that it was restored but also deprecated)

thanks make sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants