Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add example for multiindex series and dataframe merge #32068

Merged

Conversation

ryankarlos
Copy link
Contributor

@ryankarlos ryankarlos commented Feb 18, 2020

@ryankarlos ryankarlos changed the title Add example in docs for multiindex series and dataframe merge DOC: Add example for multiindex series and dataframe merge Feb 18, 2020
@ryankarlos ryankarlos force-pushed the example-joining-series-with-dataframe branch from ef40b6d to f4d246f Compare February 18, 2020 02:18
@simonjayhawkins simonjayhawkins added Docs Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Feb 18, 2020
@ryankarlos
Copy link
Contributor Author

@simonjayhawkins all green now

Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ryankarlos for the PR. Other examples on this page have a graphical representation. Should this example be consistent?

@ryankarlos ryankarlos force-pushed the example-joining-series-with-dataframe branch from c0cf8b1 to 02a8159 Compare February 24, 2020 22:47
@ryankarlos
Copy link
Contributor Author

ryankarlos commented Feb 25, 2020

Pushed some changes and simplified the example - seems CI failure is unrelated

@ryankarlos ryankarlos force-pushed the example-joining-series-with-dataframe branch from 02a8159 to 30f611f Compare February 25, 2020 20:20
@ryankarlos
Copy link
Contributor Author

Rebased, all green now

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor clarification nit but otherwise lgtm

@WillAyd WillAyd added this to the 1.1 milestone Feb 27, 2020
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - ping on green

@ryankarlos ryankarlos force-pushed the example-joining-series-with-dataframe branch from 9802434 to 30e631a Compare February 27, 2020 19:55
@ryankarlos
Copy link
Contributor Author

@WillAyd All green

@WillAyd WillAyd merged commit 4800ab4 into pandas-dev:master Feb 27, 2020
@WillAyd
Copy link
Member

WillAyd commented Feb 27, 2020

Thanks @ryankarlos

@ryankarlos ryankarlos deleted the example-joining-series-with-dataframe branch February 27, 2020 21:46
@simonjayhawkins
Copy link
Member

@datapythonista can we see these merged changes or is #32279 preventing the publishing of the dev docs

@datapythonista
Copy link
Member

@datapythonista can we see these merged changes or is #32279 preventing the publishing of the dev docs

Development (master) website and docs should be available at pandas.io (dev.pandas.io should have the same, but it's the one being affected by that problem).

@simonjayhawkins
Copy link
Member

cool. should the link to the contributing guide in README.md point to https://pandas.io/docs/development/contributing.html instead of https://dev.pandas.io/docs/contributing.html

@simonjayhawkins
Copy link
Member

@ryankarlos looking at the rendered output at https://pandas.io/docs/user_guide/merging.html, the result is not displayed. see #32068 (comment)

)
ser

result = pd.merge(df, ser.reset_index(), on=['Let', 'Num'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just

   pd.merge(df, ser.reset_index(), on=['Let', 'Num'])

Copy link
Contributor Author

@ryankarlos ryankarlos Feb 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok just fixed this in PR #32370 - looking at the rendered docs - how are the diagrams of the df displayed ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok just fixed this in PR #32370

thanks

how are the diagrams of the df displayed ?

since we have a Series and a DataFrame, that format is probably not applicable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok - thanks. PR #32370 is all green now.

@simonjayhawkins
Copy link
Member

@datapythonista from the pandas.io link, is there a link to the latest released docs (i.e. 1.0.1). the documentation link under Latest version: 1.0.1 links to 1.1.0.dev0+641.g7d9c20073 docs whereas the docs links to previous versions link to the correct docs.

@datapythonista
Copy link
Member

@simonjayhawkins I sent an email to pandas-dev some days ago to try decide on the domains. Originally everybody looked happy with just using directories under pandas.io. But looks like finally the preference is to drop pandas.io (including dev.pandas.io), and just use pandas.pydata.org (the dev docs should be a directory there). The first PR to move into that direction is giving some problems with the ssh key, and I don't have permissions to this repo settings and not yet to the server. So things will move slowly until we clean up the mess with the domains and the structure.

@simonjayhawkins
Copy link
Member

Thanks @datapythonista So it maybe worth updating the README.md, even as a temporary measure, as I think it is important this link should point to the latest docs. I'll open a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Equivalent of Series.map for DataFrame
4 participants