-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Add example for multiindex series and dataframe merge #32068
DOC: Add example for multiindex series and dataframe merge #32068
Conversation
ryankarlos
commented
Feb 18, 2020
•
edited
Loading
edited
- closes Equivalent of Series.map for DataFrame #12550
ef40b6d
to
f4d246f
Compare
@simonjayhawkins all green now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ryankarlos for the PR. Other examples on this page have a graphical representation. Should this example be consistent?
c0cf8b1
to
02a8159
Compare
Pushed some changes and simplified the example - seems CI failure is unrelated |
02a8159
to
30f611f
Compare
Rebased, all green now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor clarification nit but otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm - ping on green
9802434
to
30e631a
Compare
@WillAyd All green |
Thanks @ryankarlos |
@datapythonista can we see these merged changes or is #32279 preventing the publishing of the dev docs |
Development (master) website and docs should be available at pandas.io (dev.pandas.io should have the same, but it's the one being affected by that problem). |
cool. should the link to the contributing guide in README.md point to https://pandas.io/docs/development/contributing.html instead of https://dev.pandas.io/docs/contributing.html |
@ryankarlos looking at the rendered output at https://pandas.io/docs/user_guide/merging.html, the result is not displayed. see #32068 (comment) |
) | ||
ser | ||
|
||
result = pd.merge(df, ser.reset_index(), on=['Let', 'Num']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just
pd.merge(df, ser.reset_index(), on=['Let', 'Num'])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok just fixed this in PR #32370 - looking at the rendered docs - how are the diagrams of the df displayed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok just fixed this in PR #32370
thanks
how are the diagrams of the df displayed ?
since we have a Series and a DataFrame, that format is probably not applicable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok - thanks. PR #32370 is all green now.
@datapythonista from the pandas.io link, is there a link to the latest released docs (i.e. 1.0.1). the documentation link under Latest version: 1.0.1 links to 1.1.0.dev0+641.g7d9c20073 docs whereas the docs links to previous versions link to the correct docs. |
@simonjayhawkins I sent an email to pandas-dev some days ago to try decide on the domains. Originally everybody looked happy with just using directories under pandas.io. But looks like finally the preference is to drop pandas.io (including dev.pandas.io), and just use pandas.pydata.org (the dev docs should be a directory there). The first PR to move into that direction is giving some problems with the ssh key, and I don't have permissions to this repo settings and not yet to the server. So things will move slowly until we clean up the mess with the domains and the structure. |
Thanks @datapythonista So it maybe worth updating the README.md, even as a temporary measure, as I think it is important this link should point to the latest docs. I'll open a PR for this. |