BUG: read_csv: fix wrong exception on permissions issue #32737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will add tests and whatsnew later, for now curious if it passes the windows build. |
WillAyd
reviewed
Mar 16, 2020
pandas/_libs/src/parser/io.c
Outdated
| @@ -62,6 +66,11 @@ void *new_file_source(char *fname, size_t buffer_size) { | |||
| #endif | |||
| if (fs->fd == -1) { | |||
| free(fs); | |||
| #ifdef USE_WIN_UTF16 | |||
There was a problem hiding this comment.
Is this not applicable to the above calls? If it is you can just make a macro for it in portable.h
There was a problem hiding this comment.
I removed the special case handling for Windows. I checked the python code and PyErr_SetFromErrnoWithFilename works also in Windows
roberthdevries
force-pushed
the
fix-23784-fix-wrong-exception-on-permissions
branch
2 times, most recently
from
a9393e9 to
ffcc4f6
Compare
roberthdevries
changed the title
| os.chmod(path, 0) # make file unreadable | ||
| with pytest.raises(PermissionError, match=msg) as e: | ||
| parser.read_csv(path) | ||
| assert path == e.value.filename |
There was a problem hiding this comment.
i think this assertion needs to be un-indented
There was a problem hiding this comment.
You are absolutely right and the test before this one had the same issue (I copied it from that test). That one is fixed as well.
Get rid of all error printf's and produce proper Python exceptions
PyErr_SetFromErrnoWithFilename works for Unix and Windows
roberthdevries
force-pushed
the
fix-23784-fix-wrong-exception-on-permissions
branch
from
3f29d8d to
f14b501
Compare
roberthdevries
changed the title
jreback
approved these changes
Mar 19, 2020
|
@gfyoung if any comments. |
gfyoung
reviewed
Mar 19, 2020
Co-Authored-By: gfyoung <gfyoung17+GitHub@gmail.com>
gfyoung
approved these changes
Mar 19, 2020
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
…2737) * Generate exception from the C code in the proper manner Get rid of all error printf's and produce proper Python exceptions * Declare some more exceptions from C code * Remove special case error message for c parser * Add whatsnew entry * Fix missing semicolons * Add regression test * Remove special case handling for Windows PyErr_SetFromErrnoWithFilename works for Unix and Windows * Remove call to GetLastError(), when using 0, the python error code handles this * black fixes * Fix indentation of assert statement (also in previous test, same error) * Skip the test on windows * Fix black issue * Let new_mmap fail without exception to allow fallback * Do not create a python error in new_mmap to allow the fallback to work silently * Remove the NULL pointer check for new_rd_source now that it will raise an exception * Update doc/source/whatsnew/v1.1.0.rst Co-Authored-By: gfyoung <gfyoung17+GitHub@gmail.com> Co-authored-by: Jeff Reback <jeff@reback.net> Co-authored-by: gfyoung <gfyoung17+GitHub@gmail.com>
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 23, 2020
…2737) * Generate exception from the C code in the proper manner Get rid of all error printf's and produce proper Python exceptions * Declare some more exceptions from C code * Remove special case error message for c parser * Add whatsnew entry * Fix missing semicolons * Add regression test * Remove special case handling for Windows PyErr_SetFromErrnoWithFilename works for Unix and Windows * Remove call to GetLastError(), when using 0, the python error code handles this * black fixes * Fix indentation of assert statement (also in previous test, same error) * Skip the test on windows * Fix black issue * Let new_mmap fail without exception to allow fallback * Do not create a python error in new_mmap to allow the fallback to work silently * Remove the NULL pointer check for new_rd_source now that it will raise an exception * Update doc/source/whatsnew/v1.1.0.rst Co-Authored-By: gfyoung <gfyoung17+GitHub@gmail.com> Co-authored-by: Jeff Reback <jeff@reback.net> Co-authored-by: gfyoung <gfyoung17+GitHub@gmail.com>
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 25, 2020
…2737) * Generate exception from the C code in the proper manner Get rid of all error printf's and produce proper Python exceptions * Declare some more exceptions from C code * Remove special case error message for c parser * Add whatsnew entry * Fix missing semicolons * Add regression test * Remove special case handling for Windows PyErr_SetFromErrnoWithFilename works for Unix and Windows * Remove call to GetLastError(), when using 0, the python error code handles this * black fixes * Fix indentation of assert statement (also in previous test, same error) * Skip the test on windows * Fix black issue * Let new_mmap fail without exception to allow fallback * Do not create a python error in new_mmap to allow the fallback to work silently * Remove the NULL pointer check for new_rd_source now that it will raise an exception * Update doc/source/whatsnew/v1.1.0.rst Co-Authored-By: gfyoung <gfyoung17+GitHub@gmail.com> Co-authored-by: Jeff Reback <jeff@reback.net> Co-authored-by: gfyoung <gfyoung17+GitHub@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of all error printf's and produce proper Python exceptions
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff