CLN: remove _ndarray_values #32768
Merged
CLN: remove _ndarray_values #32768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
requested changes
Mar 18, 2020
pandas/core/arrays/categorical.py
Outdated
| @@ -2570,8 +2566,7 @@ def _get_codes_for_values(values, categories): | |||
| if dtype_equal: | |||
| # To prevent erroneous dtype coercion in _get_data_algo, retrieve | |||
| # the underlying numpy array. gh-22702 | |||
| values = getattr(values, "_ndarray_values", values) | |||
| categories = getattr(categories, "_ndarray_values", categories) | |||
| pass | |||
There was a problem hiding this comment.
This is nice on a first pass at the diff, but probably better just to blow this branch away
pandas/core/indexes/base.py
Outdated
| @@ -623,7 +622,10 @@ def ravel(self, order="C"): | |||
| -------- | |||
| numpy.ndarray.ravel | |||
| """ | |||
| return self._ndarray_values.ravel(order=order) | |||
| values = self._values | |||
| if not isinstance(values, np.ndarray): | |||
There was a problem hiding this comment.
Is there not a more generic way to accomplish this?
|
boom! |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 23, 2020
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff