BUG/API: _values_for_factorize/_from_factorized round-trip #32798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
requested changes
Mar 18, 2020
|
@jorisvandenbossche objections? |
|
Yes, see my comment, we should first discuss further in the issue before simply changing |
pandas/core/arrays/boolean.py
Outdated
| @@ -320,7 +320,8 @@ def _values_for_factorize(self) -> Tuple[np.ndarray, int]: | |||
|
|
|||
| @classmethod | |||
| def _from_factorized(cls, values, original: "BooleanArray") -> "BooleanArray": | |||
| return cls._from_sequence(values, dtype=original.dtype) | |||
| mask = values == -1 | |||
| return cls(values.astype(bool), mask) | |||
There was a problem hiding this comment.
The astype causes a copy, which I think wasn't present before. This could perhaps be a .view('bool') to preserve the previous no-copy behavior.
There was a problem hiding this comment.
changed to .astype(bool, copy=False)
|
mothballing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffhaving this round-trip-ability is necessary for implementing an efficient general-case broadcast_to/tile compat method.