REGR: Fix bug when replacing categorical value with self #33292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM pending green |
|
@dsaxton If you rebase it should fix the Travis issue |
|
@dsaxton I've tagged this as 1.0.4 for now since #33288 is a regression. I don't think need to move whatsnew yet, see #33157 (comment) opened #33300 to help keep track and discuss |
simonjayhawkins
added
Regression
simonjayhawkins
changed the title
jreback
requested changes
Apr 5, 2020
pandas/core/arrays/categorical.py
Outdated
| @@ -2463,7 +2463,8 @@ def replace(self, to_replace, value, inplace: bool = False): | |||
| if new_value in cat.categories: | |||
There was a problem hiding this comment.
you can move this check to line 2451, e.g.
elif replace_value == new_value:
continue
| @@ -64,6 +64,7 @@ def test_isin_cats(): | |||
| [ | |||
| ("b", "c", ["a", "c"], "Categorical.categories are different"), | |||
| ("c", "d", ["a", "b"], None), | |||
| ("a", "a", ["a", "b"], None), | |||
There was a problem hiding this comment.
can you annotate this case (add a comment on line before with this issue number)
|
@dsaxton if other comments are addressed, can you re-push? the docbuild should be OK now |
jreback
approved these changes
Apr 6, 2020
|
thanks @dsaxton |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Apr 11, 2020
simonjayhawkins
pushed a commit
to simonjayhawkins/pandas
that referenced
this pull request
May 5, 2020
…acing categorical value with self)
simonjayhawkins
added a commit
that referenced
this pull request
May 5, 2020
…gorical value with self) (#34004) Co-authored-by: Daniel Saxton <2658661+dsaxton@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff