Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: data_columns can take bool #33768

Merged
merged 2 commits into from
Apr 24, 2020
Merged

DOC: data_columns can take bool #33768

merged 2 commits into from
Apr 24, 2020

Conversation

klieret
Copy link
Contributor

@klieret klieret commented Apr 24, 2020

The data_columns argument of df.to_hdf can take True as an argument, meaning "all columns", yet the type hint is Optional[List[str]], triggering warnings in e.g. pyCharm.

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback jreback added the Typing type annotations, mypy/pyright type checking label Apr 24, 2020
@jreback jreback added this to the 1.1 milestone Apr 24, 2020
@jreback jreback merged commit 3df51fc into pandas-dev:master Apr 24, 2020
@jreback
Copy link
Contributor

jreback commented Apr 24, 2020

thanks!

rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request May 10, 2020
@klieret @rhshadrach
DOC: data_columns can take bool (pandas-dev#33768)
8656c2b
@klieret klieret deleted the fix-type-hint-to-hdf branch April 30, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@klieret @jreback