REF: Create numba helper function for jitting + generating cache key #33910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
May 1, 2020
| @@ -77,11 +77,8 @@ | |||
| from pandas.core.series import Series | |||
| from pandas.core.util.numba_ import ( | |||
| NUMBA_FUNC_CACHE, | |||
There was a problem hiding this comment.
can you remove the CACHE from here as well?
There was a problem hiding this comment.
There are some separate code paths that store the function in the cache independently
There was a problem hiding this comment.
i c. ideally this is not visible at all in this code if at all possible (this is what I mean by using a Dispatcher, e.g. that you would be how you would interactive with the function & cache itself). but i guess that's for the future.
There was a problem hiding this comment.
Ah I see. Okay I can look into that in a future PR when playing around more with a Dispatcher
jreback
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff