Bug in DataFrame.replace casts columns to object dtype if items in to_replace not in values
#34048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Dtype Conversions
jreback
requested changes
May 7, 2020
|
I am ok with reverting things for the 1.0.4 branch but not for master. |
jbrockmendel
reviewed
May 7, 2020
simonjayhawkins
changed the title
object dtype if items in to_replace not in values
jreback
approved these changes
May 9, 2020
|
thanks @simonjayhawkins |
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
…n ``to_replace`` not in values (pandas-dev#34048)
5 tasks
simonjayhawkins
added a commit
to simonjayhawkins/pandas
that referenced
this pull request
May 11, 2020
…e casts columns to ``object`` dtype if items in ``to_replace`` not in values)
5 tasks
simonjayhawkins
added a commit
that referenced
this pull request
May 14, 2020
…lumns to ``object`` dtype if items in ``to_replace`` not in values) (#34115)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replacecasts columns toobject#32988black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff