BUG: merge between partial index and index fails when result is empty #34414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…result is empty with inner
dsaxton
reviewed
May 27, 2020
jreback
requested changes
May 27, 2020
jreback
requested changes
May 31, 2020
� Conflicts: � doc/source/whatsnew/v1.1.0.rst
� Conflicts: � doc/source/whatsnew/v1.1.0.rst
� Conflicts: � doc/source/whatsnew/v1.2.0.rst
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
jreback
requested changes
Jan 1, 2021
doc/source/whatsnew/v1.2.0.rst
Outdated
| @@ -357,6 +357,7 @@ Reshaping | |||
| - Bug in :func:`union_indexes` where input index names are not preserved in some cases. Affects :func:`concat` and :class:`DataFrame` constructor (:issue:`13475`) | |||
| - Bug in func :meth:`crosstab` when using multiple columns with ``margins=True`` and ``normalize=True`` (:issue:`35144`) | |||
| - Bug in :meth:`DataFrame.agg` with ``func={'name':<FUNC>}`` incorrectly raising ``TypeError`` when ``DataFrame.columns==['Name']`` (:issue:`36212`) | |||
| - Fixed bug in :func:`merge` where an error was raised when performing an inner join with partial index and ``right_index`` when no overlap between indices (:issue:`33814`) | |||
� Conflicts: � doc/source/whatsnew/v1.2.0.rst � pandas/core/reshape/merge.py � pandas/tests/reshape/merge/test_merge.py
|
Done |
jreback
requested changes
Jan 3, 2021
| @@ -2375,3 +2375,15 @@ def test_merge_right_left_index(): | |||
| } | |||
| ) | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
|
|
|||
| def test_merge_empty_right_index_left_on(): | |||
There was a problem hiding this comment.
can you do the exact reverse as well and parameterize over it (e.g. left_index=True)
There was a problem hiding this comment.
We are already testing both cases, parametrization is not really feasible here because we have to switch the dataframes too.
Renamed the test.
phofl
changed the title
jreback
approved these changes
Jan 3, 2021
|
@jreback green |
|
thanks @phofl |
phofl
deleted the
33814_merge_partial_index_and_index_fails_empty_result
branch
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThe Issue was caused when setting the name of an numpy array.