Skip to content

solves ci issues with #34575 #34579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jreback merged 1 commit into from
Jun 4, 2020
Merged

solves ci issues with #34575 #34579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion asv_bench/benchmarks/arithmetic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ def setup(self, offset):
self.rng = rng

def time_apply_index(self, offset):
offset.apply_index(self.rng)
Copy link
Contributor

@jreback jreback Jun 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbrockmendel I guess BaseOffset is not used by the non-tick offsets.

Copy link
Contributor

@jreback jreback Jun 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and we don't have any tests for this public-ish method

Copy link
Member

@jbrockmendel jbrockmendel Jun 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should just privatize

Copy link
Member

@jbrockmendel jbrockmendel Jun 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for apply

Copy link
Contributor

@jreback jreback Jun 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree we should, but need to deprecate unfortunately......an you open an issue?

self.rng + offset


class BinaryOpsMultiIndex:
Expand Down