Backport PR #34458 on branch 1.0.x (CLN: Clean csv files in test data GH34427) #34664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test data GH34427)
|
@simonjayhawkins do you have time one of those days to do a 1.0.5 release? |
can do. do we want to include anything else, wait a few weeks before doing the release and see if anything else surfaces or just get a patch release done with the S3 changes? |
|
I would personally just do a patch release with the S3 changes, and not wait a few weeks with that. But maybe open a RLS issue for it to get some feedback from others? |
Closed
|
agree would just do the revert of the single issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #34458