Skip to content

REF: simplify advance/move/set_length in libreduction #34982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 25, 2020
Merged

REF: simplify advance/move/set_length in libreduction #34982

merged 3 commits into from
Jun 25, 2020

Conversation

jbrockmendel
Copy link
Member

Make it so that we set buf.data in fewer places. I think from here its pretty straightforward to avoid setting buf.data at all.

cc @WillAyd.

@jbrockmendel jbrockmendel mentioned this pull request Jun 25, 2020
Merged
5 tasks
@jreback jreback added Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Jun 25, 2020
@jreback jreback added this to the 1.1 milestone Jun 25, 2020
@jreback jreback merged commit 5f06c06 into pandas-dev:master Jun 25, 2020
@jreback
Copy link
Contributor

jreback commented Jun 25, 2020

thanks

@jbrockmendel jbrockmendel deleted the ref-sliders branch June 25, 2020 15:26
fangchenli pushed a commit to fangchenli/pandas that referenced this pull request Jun 27, 2020
@jbrockmendel @fangchenli
REF: simplify advance/move/set_length in libreduction (pandas-dev#34982)
c1e24f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback