Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: GH29547 format with f-strings #35013

Closed
wants to merge 1 commit into from

Conversation

DanBasson
Copy link
Contributor

xref #29547,#34914
replace .format() for f-strings in the following:

pandas/tests/series/indexing/test_numeric.py

@WillAyd
Copy link
Member

WillAyd commented Jun 26, 2020

Thanks but I think the use of format here is better than a lambda. Basically any time we have to defer string evaluation like this format is better

@WillAyd WillAyd closed this Jun 26, 2020
@DanBasson
Copy link
Contributor Author

Thanks @WillAyd .

i have a question though-when i made the recent pull request, the two CI were green but all others were red.
when i tried to follow the error i couldn't understand what the errors were.
perhaps you can tell me. what does it mean when there is a situation like that? how can i understand that better?

@WillAyd
Copy link
Member

WillAyd commented Jun 26, 2020

If you click on the Checks tab of the PR you should be able to see all of the failed builds. Click through them and you should see the test that failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants