Skip to content

xfail failing 32-bit tests #35289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Conversation

TomAugspurger
Copy link
Contributor

We need MacPython to be passing for the wheels to be built.

@TomAugspurger TomAugspurger added the 32bit 32-bit systems label Jul 15, 2020
@@ -18,6 +18,7 @@
PY38 = sys.version_info >= (3, 8)
PY39 = sys.version_info >= (3, 9)
PYPY = platform.python_implementation() == "PyPy"
IS64 = sys.maxsize > 2 ** 32
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't imagine it matters in practice but in theory this should be 2 ** 32 - 1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this from https://docs.python.org/3/library/platform.html#cross-platform

is_64bits = sys.maxsize > 2**32

@jreback jreback added this to the 1.1 milestone Jul 15, 2020
@jreback jreback merged commit 7b718ba into pandas-dev:master Jul 15, 2020
@TomAugspurger TomAugspurger deleted the xfail-32 branch July 15, 2020 20:27
fangchenli pushed a commit to fangchenli/pandas that referenced this pull request Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
32bit 32-bit systems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants