Skip to content

DOC: Rst Formatting, make sure continuation prompt are used. #35317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Jul 17, 2020

Without the ... for some tools it may look like
with ExcelWriter('path_to_file.xlsx', is an input and
date... is the output.

I initially thought that I could use the hanging indent to separate
code continuation from output but pandas/core/indexing.py
proved me wrong as the example just after the one I fixed have
the first line of the output be indented.

Without the `...` for some tools it may look like
`with ExcelWriter('path_to_file.xlsx',` is an input and
`date...` is the output.

I initially thought that I could use the hanging indent to separate
code continuation from output but `pandas/core/indexing.py`
proved me wrong as the example just after the one I fixed have
the first line of the output be indented.
@WillAyd
Copy link
Member

WillAyd commented Jul 21, 2020

Can you build these docstrings to check how these render? I think OK but good to check

@WillAyd WillAyd added the Docs label Jul 21, 2020
@Carreau
Copy link
Contributor Author

Carreau commented Jul 22, 2020

Unfortunately I didn't manage to build pandas nor the docs. I came across this via another tools on my prebuilt pandas install from conda.

@WillAyd WillAyd added this to the 1.2 milestone Sep 10, 2020
@WillAyd WillAyd merged commit 03c7040 into pandas-dev:master Sep 10, 2020
@WillAyd
Copy link
Member

WillAyd commented Sep 10, 2020

Thanks @Carreau

kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants