REGR: Check for float in isnaobj_old #35510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsaxton
added
IO CSV
jbrockmendel
reviewed
Aug 2, 2020
jreback
requested changes
Aug 2, 2020
doc/source/whatsnew/v1.1.1.rst
Outdated
| @@ -15,7 +15,7 @@ including other versions of pandas. | |||
| Fixed regressions | |||
| ~~~~~~~~~~~~~~~~~ | |||
|
|
|||
| - | |||
| - Fixed regression where :func:`read_csv` would raise a ``ValueError`` when ``use_inf_as_na`` was set to ``True`` (:issue:`35493`). | |||
There was a problem hiding this comment.
write out the path to the option
|
|
||
|
|
||
| def test_read_csv_with_use_inf_as_na(all_parsers): | ||
| # https://github.com/pandas-dev/pandas/issues/35493 |
There was a problem hiding this comment.
see if u can locate this test near others that set options (not kwargs)
There was a problem hiding this comment.
The others that use options seem to be in more targeted testing files (test_to_html.py, test_printing.py); this is the only one in this file
gfyoung
approved these changes
Aug 2, 2020
jreback
approved these changes
Aug 3, 2020
|
thanks @dsaxton |
|
backport to 1.1.x |
|
@simonjayhawkins hmm these don't seem to be triggering a backport action. any idea? |
|
|
@meeseeksdev backport to 1.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 4, 2020
simonjayhawkins
pushed a commit
that referenced
this pull request
Aug 4, 2020
Co-authored-by: Daniel Saxton <2658661+dsaxton@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffLooks like we lost an isinstance check that caused this regression.