TYP/CLN: cleanup _openpyxl.py, add type annotation #36021
#36022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangchenli
changed the title
_openpyxl.py, add type annotation #36021
fangchenli
commented
Sep 1, 2020
| @@ -515,16 +484,17 @@ def get_sheet_by_index(self, index: int): | |||
|
|
|||
| def _convert_cell(self, cell, convert_float: bool) -> Scalar: | |||
|
|
|||
| # TODO: replace with openpyxl constants | |||
| from openpyxl.cell.cell import TYPE_BOOL, TYPE_ERROR, TYPE_NUMERIC | |||
|
|
|||
There was a problem hiding this comment.
openpyxl verion < 2.6 would raise import error here.
fangchenli
commented
Sep 1, 2020
simonjayhawkins
requested changes
Sep 1, 2020
There was a problem hiding this comment.
Thanks @VirosaLi for the PR.
if updating minimum versions need to update Increased minimum versions for dependencies of doc\source\whatsnew\v1.2.0.rst and pandas\doc\source\getting_started\install.rst
I'm not sure whether we want to update minimum versions just for typing @WillAyd
|
@VirosaLi to fix the import errors, use quotes around the type (or can use |
fangchenli
commented
Sep 1, 2020
| return self.book.save(self.path) | ||
|
|
||
| @classmethod | ||
| def _convert_to_style(cls, style_dict): |
There was a problem hiding this comment.
I don't see this method is used anywhere. And it doesn't affect any test. Also, it seems like openpyxl doesn't have a style module anymore.
WillAyd
reviewed
Sep 1, 2020
sarthakvk
pushed a commit
to sarthakvk/pandas
that referenced
this pull request
Sep 2, 2020
…ev#36021 (pandas-dev#36022)" This reverts commit ecc5015.
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_openpyxl.py, add type annotation #36021black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff