Skip to content

Concatenating rows with Int64 datatype coerces to object #36278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2020

Conversation

phofl
Copy link
Member

@phofl phofl commented Sep 10, 2020

Issue was fixed in the past.

@phofl phofl added the Reshaping Concat, Merge/Join, Stack/Unstack, Explode label Sep 10, 2020
@WillAyd
Copy link
Member

WillAyd commented Sep 10, 2020

The test itself looks good just not sure on location - @jreback should this go in pandas/tests/extension/test_integer.py::TestReshaping or is that intended for something else?

@phofl
Copy link
Member Author

phofl commented Sep 10, 2020

I added it there, because directly above is a similar test. If we move the new test, we should move that one too.

@jreback jreback changed the title [TST]: Add test for 24768 Concatenating rows with Int64 datatype coerces to object Sep 13, 2020
@jreback jreback added Dtype Conversions Unexpected or buggy dtype conversions Testing pandas testing functions or related to the test suite labels Sep 13, 2020
@jreback jreback added this to the 1.2 milestone Sep 13, 2020
@jreback jreback merged commit 1b2f1f4 into pandas-dev:master Sep 13, 2020
@jreback
Copy link
Contributor

jreback commented Sep 13, 2020

nah this looks like a good location. thanks @phofl

@phofl phofl deleted the 24768 branch September 13, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions Reshaping Concat, Merge/Join, Stack/Unstack, Explode Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concatenating rows with Int64 datatype coerces to object
3 participants