Skip to content

BUG: Don't overflow with large int scalar #36316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2020
Merged

BUG: Don't overflow with large int scalar #36316

merged 2 commits into from
Sep 13, 2020

Conversation

dsaxton
Copy link
Member

@dsaxton dsaxton commented Sep 12, 2020

@dsaxton dsaxton added Bug Constructors Series/DataFrame/Index/pd.array Constructors Series Series data structure labels Sep 13, 2020
@dsaxton dsaxton added this to the 1.1.3 milestone Sep 13, 2020
@jreback jreback merged commit 22374c3 into pandas-dev:master Sep 13, 2020
@jreback
Copy link
Contributor

jreback commented Sep 13, 2020

thanks @dsaxton

if you can run the construction asv's just to confirm no regression would be great

@dsaxton dsaxton deleted the integer-overflow-series branch September 13, 2020 13:06
@simonjayhawkins
Copy link
Member

@meeseeksdev backport 1.1.x

@dsaxton
Copy link
Member Author

dsaxton commented Sep 13, 2020

@jreback Ran series_methods.py asvs (which includes Series construction) and performance improved (probably a false positive):

     <master>         <integer-overflow-series>
-         137±4μs          117±3μs     0.85  series_methods.NanOps.time_func('std', 1000, 'boolean')

SOME BENCHMARKS HAVE CHANGED SIGNIFICANTLY.
PERFORMANCE INCREASED.

simonjayhawkins pushed a commit that referenced this pull request Sep 13, 2020
Co-authored-by: Daniel Saxton <2658661+dsaxton@users.noreply.github.com>
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Constructors Series/DataFrame/Index/pd.array Constructors Series Series data structure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: pandas series creation fails with OverflowError when given large integers
3 participants