Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Concat typing #36409

Merged
merged 3 commits into from
Sep 19, 2020
Merged

BUG: Concat typing #36409

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b21d3ab
BUG: Typing in concat
rhshadrach Sep 16, 2020
1bea1b1
Added typing to overload.
rhshadrach Sep 16, 2020
2ab6328
Changed to NDFrame
rhshadrach Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pandas/core/reshape/concat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@

if TYPE_CHECKING:
from pandas import DataFrame
from pandas.core.generic import NDFrame

# ---------------------------------------------------------------------
# Concatenate DataFrame objects
Expand All @@ -54,7 +55,7 @@ def concat(

@overload
def concat(
objs: Union[Iterable[FrameOrSeries], Mapping[Label, FrameOrSeries]],
objs: Union[Iterable["NDFrame"], Mapping[Label, "NDFrame"]],
axis=0,
join: str = "outer",
ignore_index: bool = False,
Expand All @@ -69,7 +70,7 @@ def concat(


def concat(
objs: Union[Iterable[FrameOrSeries], Mapping[Label, FrameOrSeries]],
objs: Union[Iterable["NDFrame"], Mapping[Label, "NDFrame"]],
axis=0,
join="outer",
ignore_index: bool = False,
Expand Down