Skip to content

REGR: Series.loc with a MultiIndex containing Timestamp raises InvalidIndexError #36675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

simonjayhawkins
Copy link
Member

ci testing fix in #35858 (comment)

@simonjayhawkins simonjayhawkins added Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex labels Sep 26, 2020
@simonjayhawkins simonjayhawkins added this to the 1.1.3 milestone Sep 26, 2020
@jreback
Copy link
Contributor

jreback commented Sep 26, 2020

can you add the test from the OP as well

@simonjayhawkins
Copy link
Member Author

yep. the fix looks good. will add release note and tests shortly.

@simonjayhawkins simonjayhawkins added Regression Functionality that used to work in a prior pandas version Datetime Datetime data dtype labels Sep 27, 2020
@simonjayhawkins simonjayhawkins changed the title Testing on ci - BUG: Datetime MultiIndex Regression REGR: Series.loc with a MultiIndex containing Timestamp raises InvalidIndexError Sep 27, 2020
@simonjayhawkins simonjayhawkins marked this pull request as ready for review September 27, 2020 20:35
@simonjayhawkins
Copy link
Member Author

I can't block by requesting changes on my own PR, moving to 1.1.4 so release note needs to be moved. closing for now instead. Will re-open after 1.1.3 release.

I've started the final release readiness checks. merging now would require going back to square one.

@simonjayhawkins
Copy link
Member Author

@jreback re-opened just in case this is almost ready

@jreback jreback merged commit 469ad52 into pandas-dev:master Oct 2, 2020
@jreback
Copy link
Contributor

jreback commented Oct 2, 2020

lgtm.

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Oct 2, 2020
@simonjayhawkins simonjayhawkins deleted the Datetime-MultiIndex-Regression branch October 3, 2020 09:51
simonjayhawkins added a commit that referenced this pull request Oct 3, 2020
…x containing Timestamp raises InvalidIndexError) (#36818)

Co-authored-by: Simon Hawkins <simonjayhawkins@gmail.com>
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Datetime MultiIndex Regression
2 participants