BUG: df.diff axis=1 mixed dtypes #36710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Sep 30, 2020
| # TODO(EA2D): doing this in a loop unnecessary with 2D EAs | ||
| # Define filler inside loop so we get a copy | ||
| filler = self.iloc[:, 0].shift(len(self)) | ||
| result.insert(0, col, filler, allow_duplicates=True) |
There was a problem hiding this comment.
aren't these inplace? do we really want that? (or does .iloc do an implict copy the way you have it), i don't remember exactly
There was a problem hiding this comment.
it is inplace on result which we havent returned to the user yet
| ), | ||
| ) | ||
| def diff(self, periods: int = 1, axis: Axis = 0) -> DataFrame: | ||
| if not isinstance(periods, int): |
jreback
added
Dtype Conversions
jreback
approved these changes
Oct 7, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff