BUG: Add trailing trailing newline in to_json #36898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_lines` method. Also reformatted and merged the code with latest master branch
Member
|
can you add a test for this |
Contributor
Author
@jbrockmendel Yes. Will do that |
…ed master changes into current branch
Contributor
Author
|
@jbrockmendel added a test for the bug. And also fixed the breaking tests. |
Member
|
cc @WillAyd |
WillAyd
approved these changes
Oct 8, 2020
Contributor
Author
|
Can anyone of you complete the PR. @jbrockmendel @WillAyd . There will be again a lot of conflicts if delayed 👍 |
Contributor
|
thanks @Rohith295 |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
bencap
added a commit
to seattleflu/id3c
that referenced
this pull request
Jul 29, 2022
We recently upgraded from Pandas 1.1.5 to Pandas 1.4.3. In Pandas 1.2, a bug was fixed that prevented trailing whitespaces from being added to the end of dumped ndjson output. See [here](pandas-dev/pandas#36898) for additional information. This change uses `rstrip` on the dumped ndjson output so that all trailing whitespace is removed before this data is dumped to stdout (or a destination file). Note that this trailing newline affected our assumptions about the structure of NDJSON files and thus prevented files created after the upgrade from being parsed without error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff