CLN: move maybe_casted_values from pandas/core/frame.py to pandas/core/dtype/cast.py #36985
Conversation
|
For something thats only used once, im not sure it is worth moving. Definitely worth seeing if this can be simplified though, per a couple of TODO comments in there |
arw2019
force-pushed
the
move_maybe_casted_values_to_cast
branch
2 times, most recently
from
ee5e2e0 to
b59f39b
Compare
| values_type = type(values) | ||
| values_dtype = values.dtype | ||
|
|
||
| from pandas.core.arrays.datetimelike import DatetimeLikeArrayMixin |
There was a problem hiding this comment.
not sure this is acceptable - will change if not. The issue is we can't just import at the top of the file because of a circular import
There was a problem hiding this comment.
you could do needs_i8_conversion(values.dtype) and isinstance(values, ExtensionArray)
There was a problem hiding this comment.
ok fine with cleaning this up after, this routine definitely needs it (and also possibly is duplicative of things in this file anyways)
There was a problem hiding this comment.
you could do
needs_i8_conversion(values.dtype) and isinstance(values, ExtensionArray)
tried it and it broke some tests. I'll investigate in the follow-on
@jbrockmendel Will do! (in a followon) |
arw2019
force-pushed
the
move_maybe_casted_values_to_cast
branch
2 times, most recently
from
988354d to
c349f82
Compare
| values_type = type(values) | ||
| values_dtype = values.dtype | ||
|
|
||
| from pandas.core.arrays.datetimelike import DatetimeLikeArrayMixin |
There was a problem hiding this comment.
ok fine with cleaning this up after, this routine definitely needs it (and also possibly is duplicative of things in this file anyways)
arw2019
force-pushed
the
move_maybe_casted_values_to_cast
branch
from
c349f82 to
20c2620
Compare
|
ping on green-ish (meaning either green or a specific buidl is failing on completely unrelated; though I think @jbrockmendel may have fixed this). |
|
thanks @arw2019 if you can rebase the typing one on master would be great. |
Thanks @jreback @jbrockmendel for reviewing!
Done |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffxref #36876, #27370 (stale PR)