DOC: Improve what the axis= kwarg does for generic methods
#37029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arw2019
reviewed
Oct 10, 2020
Contributor
arw2019
left a comment
arw2019
left a comment
There was a problem hiding this comment.
Thanks @hongshaoyang for the PR!
I agree this is worth improving. However, I think that a better preposition would be along or over rather than across. See, for example, the numpy docs for np.sum:
https://numpy.org/doc/stable/reference/generated/numpy.sum.html#numpy.sum
I'm -1 on this as is
hongshaoyang
force-pushed
the
personal/shaoyang
branch
from
686560a to
a5afd7f
Compare
Contributor
Author
|
Thank you @arw2019 for the review! I agree that "over" is clearer, and have changed accordingly. |
arw2019
approved these changes
Oct 10, 2020
Contributor
Author
rhshadrach
added
hacktoberfest-accepted
Docs
Numeric Operations
rhshadrach
approved these changes
Oct 10, 2020
Member
rhshadrach
left a comment
rhshadrach
left a comment
There was a problem hiding this comment.
lgtm; I've verified this takes care of all docs that use the phrase "requested axis".
Contributor
|
can you merge master (and ping on green), we just moved a lot of this around. |
hongshaoyang
force-pushed
the
personal/shaoyang
branch
from
a5afd7f to
f5c58ec
Compare
hongshaoyang
force-pushed
the
personal/shaoyang
branch
from
f5c58ec to
0cd70de
Compare
Contributor
Author
|
all checks passing @jreback |
Contributor
|
thanks @hongshaoyang |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Oct 26, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
axis=0oraxis=1, which is it?Opening a PR to discuss #29203 on what it means to do
df.sum(axis=0)versusdf.sum(axis=1). The docs does not make it intuitively clear to the user. I propose a simple change where "summing acrossaxis=0" makes it clear that you're summing across indexes (i.e. column sums).black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff