Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "CLN: core/dtypes/cast.py::maybe_downcast_to_dtype" #37116

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Revert "CLN: core/dtypes/cast.py::maybe_downcast_to_dtype" #37116

merged 1 commit into from
Oct 14, 2020

Conversation

simonjayhawkins
Copy link
Member

Reverts #37050

@simonjayhawkins
Copy link
Member Author

opened to get mypy to green. other options available xref #37050 (comment)

cc @arw2019

@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Oct 14, 2020
@simonjayhawkins simonjayhawkins added the CI Continuous Integration label Oct 14, 2020
@simonjayhawkins
Copy link
Member Author

failure unrelated

=========================== short test summary info ============================
FAILED pandas/tests/io/test_html.py::TestReadHtml::test_banklist_url_positional_match[bs4]
= 1 failed, 88193 passed, 1148 skipped, 1446 xfailed, 74 warnings in 1718.54s (0:28:38) =

@simonjayhawkins simonjayhawkins merged commit c0c3516 into master Oct 14, 2020
@simonjayhawkins simonjayhawkins deleted the revert-37050-maybe_downcast_to_dtype_cleanup branch October 14, 2020 16:41
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
@simonjayhawkins @JulianWgs
Revert "CLN: core/dtypes/cast.py::maybe_downcast_to_dtype (pandas-dev…
fee0afa 
…#37050)" (pandas-dev#37116)

This reverts commit fad14fd.
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@simonjayhawkins
Revert "CLN: core/dtypes/cast.py::maybe_downcast_to_dtype (pandas-dev…
33d7b8d 
…#37050)" (pandas-dev#37116)

This reverts commit fad14fd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
1 participant
@simonjayhawkins