Skip to content

[WIP] Arrow string array: Split array and dtype #37336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from
Closed

[WIP] Arrow string array: Split array and dtype #37336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
4c2e37a
Implement BaseDtypeTests for ArrowStringDtype
xhochy Jul 10, 2020
d477ee7
Implement getitem
xhochy Jul 13, 2020
206f493
Add basic copy implementation
xhochy Jul 13, 2020
d58dba6
Implement getitem for iterables
xhochy Jul 13, 2020
7a9e2c3
Remove commented code
xhochy Jul 13, 2020
ffc4c0f
Implement more Setitem/Getitem variants
xhochy Jul 13, 2020
c1305ab
Review comments by @jorisvandenbossche
xhochy Jul 13, 2020
13a42f7
Add Arrow issue numbers
xhochy Jul 13, 2020
decd022
Adopt to kernel renamings
xhochy Jul 15, 2020
3145e44
Handle take(indices<0, allow_fill=False)
xhochy Jul 15, 2020
e22b348
Handle fill_value better
xhochy Jul 15, 2020
4b8108c
Merge remote-tracking branch 'upstream/master' into arrow-string-array
simonjayhawkins Oct 19, 2020
2446562
fix doctest
simonjayhawkins Oct 19, 2020
a0dcc85
Revert "fix doctest"
simonjayhawkins Oct 19, 2020
5c42173
change version for versionadded
simonjayhawkins Oct 19, 2020
28c3ef2
code checks
simonjayhawkins Oct 19, 2020
4044d4c
Merge remote-tracking branch 'upstream/master' into arrow-string-array
simonjayhawkins Oct 21, 2020
1740524
skip tests for pyarrow<1.0
simonjayhawkins Oct 21, 2020
2c9dec9
split array and dtype
simonjayhawkins Oct 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pandas/core/arrays/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,14 +455,19 @@ def astype(self, dtype, copy=True):
NumPy ndarray with 'dtype' for its dtype.
"""
from pandas.core.arrays.string_ import StringDtype
from pandas.core.arrays.string_arrow import ArrowStringDtype

dtype = pandas_dtype(dtype)
if is_dtype_equal(dtype, self.dtype):
if not copy:
return self
elif copy:
return self.copy()
if isinstance(dtype, StringDtype): # allow conversion to StringArrays

# FIXME: Really hard-code here?
if isinstance(
dtype, (ArrowStringDtype, StringDtype)
): # allow conversion to StringArrays
return dtype.construct_array_type()._from_sequence(self, copy=False)

return np.array(self, dtype=dtype, copy=copy)
Expand Down
3 changes: 3 additions & 0 deletions pandas/core/arrays/string_arrow/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# flake8: noqa: F401

from pandas.core.arrays.string_arrow.dtype import ArrowStringDtype
Loading