-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
[WIP] Arrow string array: Common base class #37337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Arrow string array: Common base class #37337
Conversation
This reverts commit 2446562.
@@ -240,3 +241,11 @@ def _reduce(self, name: str, skipna: bool = True, **kwargs): | |||
else: | |||
msg = f"'{type(self).__name__}' does not implement reduction '{name}'" | |||
raise TypeError(msg) | |||
|
|||
|
|||
class StringArrayBase(ExtensionArray): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was for consistency with StringDtypeBase below and a first step towards #35169 (comment)
not actually needed for task in hand, i.e. fix astype failures.
pass | ||
|
||
|
||
class StringDtypeBase(ExtensionDtype): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could alternative live in pandas\core\dtypes\base.py (might also prevent circular imports)
CI testing alternative to #37336