Skip to content

BUG: Bug in DataFrame.loc for setitem changed dtype when setting more than one column #37798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

BUG: Bug in DataFrame.loc for setitem changed dtype when setting more than one column #37798

wants to merge 8 commits into from

Conversation

phofl
Copy link
Member

@phofl phofl commented Nov 12, 2020

Could not find a reason why we should convert the dtype to object, if values is already an array.

@phofl phofl added Dtype Conversions Unexpected or buggy dtype conversions Indexing Related to indexing on series/frames, not to indexes themselves labels Nov 12, 2020
@pep8speaks
Copy link

pep8speaks commented Nov 13, 2020 •
edited
Loading

Hello @phofl! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-12-23 23:51:05 UTC

jreback
jreback requested changes Nov 15, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you merge master

@phofl
Copy link
Member Author

phofl commented Nov 15, 2020

Done

@phofl phofl mentioned this pull request Nov 22, 2020
Closed
3 tasks
@phofl phofl changed the title [BUG]: Bug in DataFrame.loc for setitem changed dtype when setting more than one column BUG: Bug in DataFrame.loc for setitem changed dtype when setting more than one column Nov 22, 2020
@phofl
Copy link
Member Author

phofl commented Nov 22, 2020

cc @jreback Merged master

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Dec 23, 2020
phofl added 2 commits December 24, 2020 00:50
@phofl
Merge branch 'master' of https://github.com/pandas-dev/pandas into 18415
56df4c6 
� Conflicts:
�	doc/source/whatsnew/v1.2.0.rst
�	pandas/tests/frame/indexing/test_setitem.py
@phofl
Move whatsnew
a1ad944
@phofl phofl removed the Stale label Dec 23, 2020
@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Jan 23, 2021
@simonjayhawkins
Copy link
Member

@phofl can you merge master to resolve conflicts

@simonjayhawkins
Copy link
Member

@phofl status on this one?

@simonjayhawkins
Copy link
Member

@phofl closing as stale. reopen when ready

@phofl phofl deleted the 18415 branch April 27, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback requested changes

Assignees
No one assigned
Labels
Dtype Conversions Unexpected or buggy dtype conversions Indexing Related to indexing on series/frames, not to indexes themselves Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent changes of dtype on assignment to multiindexed columns
4 participants
@phofl @pep8speaks @simonjayhawkins @jreback