Skip to content

Conversation

@twoertwein
Copy link
Member

test_register_writer in pandas/tests/io/excel/test_writers.py wasn't expecting that something.xls and something.xlsx will ever be created.

Since #37639, ExcelWriter opens the file which will create it.

@jbrockmendel
Copy link
Member

LGTM ping on green

@twoertwein
Copy link
Member Author

twoertwein commented Nov 15, 2020

@jbrockmendel green'ish

@jbrockmendel jbrockmendel merged commit 5c4d0aa into pandas-dev:master Nov 15, 2020
@jbrockmendel
Copy link
Member

thanks @twoertwein

@twoertwein twoertwein deleted the excel branch November 15, 2020 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants