CLN: Rolling helper attributes #38664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sure merge on green-ish |
|
|
||
| class Rolling(RollingAndExpandingMixin): | ||
| @cache_readonly | ||
| def is_datetimelike(self) -> bool: |
There was a problem hiding this comment.
Note that those attributes are public (whether we like that or not ..), and so should ideally be deprecated first if we remove them.
There was a problem hiding this comment.
(note I was looking at some rolling-related PRs because of a dask failure, see #38641 (comment), but this change about is_datetimelike didn't actually cause an issue in dask, to be clear)
There was a problem hiding this comment.
I am -1 on deprecating anything here. these are internal and never documented as public.
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffis_datetimelikewas just an internal check and can be in-lined_oncan just be calculated once in the init