Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: np.bool -> np.bool_ #39019

Merged
merged 3 commits into from
Jan 7, 2021
Merged

DOC: np.bool -> np.bool_ #39019

merged 3 commits into from
Jan 7, 2021

Conversation

simonjayhawkins
Copy link
Member

xref #34848, #34835

a couple missed that are causing doc build failures with numpy-1.20.0rc2, https://github.com/pandas-dev/pandas/pull/36092/checks?check_run_id=1662818738

probably want to backport this to prevent possible future ci failures

@simonjayhawkins simonjayhawkins added this to the 1.2.1 milestone Jan 7, 2021
jreback
jreback approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jreback
Copy link
Contributor

jreback commented Jan 7, 2021

should we have a checker rule to prohibit?

@simonjayhawkins
Copy link
Member Author

should we have a checker rule to prohibit?

possible, i used np.bool[^_] but that misses

pandas/tests/io/excel/test_writers.py:    @pytest.mark.parametrize("np_type", [np.bool8, np.bool_])
pandas/tests/io/excel/test_writers.py:        # Test np.bool values read come back as float.

could change the comment as well and use np.bool[^_8]

@simonjayhawkins @MarcoGorelli
Update .pre-commit-config.yaml
f5dd27a 
Co-authored-by: Marco Gorelli <marcogorelli@protonmail.com>
@jreback
Copy link
Contributor

jreback commented Jan 7, 2021

@simonjayhawkins you may have to remove the rule for backport but we shall see

@jreback jreback merged commit 1231e2c into pandas-dev:master Jan 7, 2021
@jreback
Copy link
Contributor

jreback commented Jan 7, 2021

@meeseeksdev backport 1.2.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 7, 2021
@simonjayhawkins @meeseeksmachine
Backport PR pandas-dev#39019: DOC: np.bool -> np.bool_
d7ce57e
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 7, 2021
Merged
@lumberbot-app
Copy link

lumberbot-app bot commented Jan 7, 2021

Something went wrong ... Please have a look at my logs.

@simonjayhawkins simonjayhawkins deleted the np.bool->-np.bool_ branch January 7, 2021 18:59
jreback pushed a commit that referenced this pull request Jan 7, 2021
@meeseeksmachine @simonjayhawkins
Backport PR #39019: DOC: np.bool -> np.bool_ (#39020)
8267ca9 
Co-authored-by: Simon Hawkins <simonjayhawkins@gmail.com>
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@simonjayhawkins @luckyvs1
DOC: np.bool -> np.bool_ (pandas-dev#39019)
61af94a
@sbrugman sbrugman mentioned this pull request Feb 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@simonjayhawkins @jreback @MarcoGorelli