-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC/REF: Rolling/Expanding/EWM docstrings #39219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @jorisvandenbossche @simonjayhawkins if you have any comments |
dtype: float64 | ||
""" | ||
), | ||
) | ||
def std(self, ddof: int = 1, *args, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OT i don't think *args should be used after the keyword argument ddof, mypy normally complains about the function receiving multiple values for argument.
EDIT: Nevermind |
hmm somthing going wrong on the docs build |
Fixed the doc build failing tests and all green. Refactored now to omit empty sections. |
ahh can you rebase |
cc @simonjayhawkins @jorisvandenbossche if any other comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mroeschke lgtm.
Going to merge and can address any follow ups in another PR |
Ensure all linting tests pass, see here for how to run them
Create a new
window/doc.py
file for common templateUsing
@doc
decorator instead of@Appender
Standardize descriptions and sections