TYP, CLN annotate some variables, remove some possibly unused ones #39466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
dmypy-errors
branch
from
6cec281 to
58b16ca
Compare
MarcoGorelli
force-pushed
the
dmypy-errors
branch
from
58b16ca to
552715a
Compare
|
looks fine. cc @simonjayhawkins |
|
can you merge master |
|
thanks @MarcoGorelli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mypy daemon throws some extra
var-annotatederrors compared withmypy pandas, so I've tried fixing some. Some of the variables it complains about seem to be unused (ExcelWriter.curr_sheet and NDFrame._ix) - are these safe to remove?